Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Nfs-support branch into main #215

Merged
merged 32 commits into from
Jul 20, 2023
Merged

Merge Nfs-support branch into main #215

merged 32 commits into from
Jul 20, 2023

Conversation

VamsiSiddu-7
Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 commented Jul 5, 2023

Description

This pr merges the nfs-support branch into main branch. The nfs-support branch contains the code changes for NFS create and delete feature into main branch

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#763

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • This was tested for the create/delete NFS feature for csi-powerflex

Sorry, something went wrong.

VamsiSiddu-7 and others added 15 commits April 17, 2023 16:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ex array. (#182)

* Add checkNfs method.

* add version check in checkNFS.

* changed the nfs topology to true.

* add debug.

* add debug1.

* add debug3.

* removed the version logic.

* add debug 4.

* move logic to service.go

* add debug 5

* add debug 6

* add debug 7.

* add debug 8.

* removed the debug logs.

* unit test changes for nodeGetInfo.

* updated go mod and go sum.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Added new storageclass for NFS support

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* helm chart update for nfs support

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Add checkNfs method.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* added helm tests for nfs.

* fixed a small mistake in the 5vols-nfs test.

* removed the ephemeral volume helm tests.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* create NFS volume implemented

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
* indentation fixed for controller.yaml

* NFS storage class yaml updated

* create NFS volume implemented

* go.mod and go.sum updated

* update controller publish volume for nfs.

* hardcoded volume name for testing.

* add debug.

* files updated

* add debug.

* removed debug statements

* add debug.

* fixed error.

* fix the panic.

* add debug.

* fixed the nil panic.

* fixed the nfs export.

* fix nfs export error.

* files updated

* updated files.

* files updated

* removed debug logs.

* remove debug logs.

* add debug.

* add debug.

* add debug3.

* fixed a mistake.

* add debug.

* fixed th idempotency.

* remove debug logs.

* removed the hardcoded name.

* address review comments.

---------

Co-authored-by: Khare <rajshree.khare@dell.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Unverified

The committer email address is not verified.
…-support

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.
VamsiSiddu-7 and others added 13 commits July 9, 2023 04:43

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
khareRajshree Rajshree Khare

Verified

This commit was signed with the committer’s verified signature.
khareRajshree Rajshree Khare

Verified

This commit was signed with the committer’s verified signature.
khareRajshree Rajshree Khare

Verified

This commit was signed with the committer’s verified signature.
khareRajshree Rajshree Khare

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.

Unverified

The committer email address is not verified.
service/features/controller_publish_unpublish.feature Outdated Show resolved Hide resolved
service/features/controller_publish_unpublish.feature Outdated Show resolved Hide resolved
service/features/controller_publish_unpublish.feature Outdated Show resolved Hide resolved
service/features/controller_publish_unpublish.feature Outdated Show resolved Hide resolved
service/features/controller_publish_unpublish.feature Outdated Show resolved Hide resolved
service/features/node_publish_unpublish.feature Outdated Show resolved Hide resolved
service/features/service.feature Outdated Show resolved Hide resolved
service/step_handlers_test.go Outdated Show resolved Hide resolved
service/step_handlers_test.go Outdated Show resolved Hide resolved
test/helm/3vols-nfs/templates/pvc.yaml Outdated Show resolved Hide resolved

Unverified

The committer email address is not verified.
@VamsiSiddu-7
Copy link
Contributor Author

@khareRajshree I have Addressed your review comments. Can you please review it again .Thanks

@VamsiSiddu-7 VamsiSiddu-7 merged commit e90fcab into main Jul 20, 2023
@khareRajshree khareRajshree deleted the nfs-support branch August 24, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants